-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services/horizon/internal/actions: Refactor accounts to use new actions system. #1827
Merged
abuiles
merged 7 commits into
release-horizon-v0.23.0
from
move-accounts-to-new-action-handler
Oct 11, 2019
Merged
services/horizon/internal/actions: Refactor accounts to use new actions system. #1827
abuiles
merged 7 commits into
release-horizon-v0.23.0
from
move-accounts-to-new-action-handler
Oct 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@abuiles I think you need to set the PR to merge into the release branch instead of master. |
@tamirms updated -- fixing the conflict. |
abuiles
commented
Oct 10, 2019
abuiles
force-pushed
the
move-accounts-to-new-action-handler
branch
from
October 10, 2019 20:55
1cc5bb2
to
f9d21c2
Compare
tamirms
reviewed
Oct 11, 2019
tamirms
approved these changes
Oct 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
Summary
Use the new action handling pattern on
/accounts
. This removes the tight coupling between thesigners
query parameter and the action. It will allow us to implement new functionalities like #442.Goal and scope
/accounts
./account
to make it easy to add extra filters.Summary of changes
/accounts
.Known limitations & issues
What shouldn't be reviewed