Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/actions: Refactor accounts to use new actions system. #1827

Merged
merged 7 commits into from
Oct 11, 2019

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Oct 10, 2019

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

Summary

Use the new action handling pattern on /accounts. This removes the tight coupling between the signers query parameter and the action. It will allow us to implement new functionalities like #442.

Goal and scope

  • Remove old action handling pattern for /accounts.
  • Use the new action handling pattern as described in Decide on Horizon's actions package #1606
  • Generalize the action handler for /account to make it easy to add extra filters.

Summary of changes

  • Remove code for old action handler pattern.
  • Introduce the new action handler pattern for /accounts.

Known limitations & issues

  • N/A

What shouldn't be reviewed

  • N/A

@abuiles abuiles requested review from bartekn and tamirms October 10, 2019 19:59
@cla-bot cla-bot bot added the cla: yes label Oct 10, 2019
@tamirms
Copy link
Contributor

tamirms commented Oct 10, 2019

@abuiles I think you need to set the PR to merge into the release branch instead of master.

@abuiles abuiles changed the base branch from master to release-horizon-v0.23.0 October 10, 2019 20:38
@abuiles
Copy link
Contributor Author

abuiles commented Oct 10, 2019

@tamirms updated -- fixing the conflict.

@abuiles abuiles force-pushed the move-accounts-to-new-action-handler branch from 1cc5bb2 to f9d21c2 Compare October 10, 2019 20:55
Copy link
Contributor

@tamirms tamirms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@abuiles abuiles merged commit 2ac805c into release-horizon-v0.23.0 Oct 11, 2019
@abuiles abuiles deleted the move-accounts-to-new-action-handler branch October 11, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants