Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/expingest: Emit error log after 3 failed attempts to validate state #1918

Merged

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Nov 13, 2019

Currently we emit error log every time there's a problem with state validation, however, sometimes temporary errors like network connection issues happen. To avoid spamming the error log we only use the error log level after encountering 3 consecutive state validation errors

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Emit error log after 3 failed attempts to validate state

Close #1822

Why

Currently we emit an error log every time there's a problem with state validation, however, sometimes temporary errors like network connection issues happen. To avoid spamming the error log we only use the error log level after encountering 3 consecutive state validation errors

Currently we emit error log every time there's a problem with state validation, however, sometimes temporary errors like network connection issues happen. To avoid spamming the error log we only use the error log level after encountering 3 consecutive state validation errors
@cla-bot cla-bot bot added the cla: yes label Nov 13, 2019
@tamirms tamirms requested review from bartekn and abuiles November 13, 2019 20:12
@tamirms tamirms merged commit 974db16 into stellar:release-horizon-v0.24.0 Nov 18, 2019
@tamirms tamirms deleted the state-verification-error-logs branch November 18, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants