services/horizon/internal/expingest/processors: Only process authorized trustlines when updating asset stats #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paging token for the asset stats rows used by the legacy ingestion system was formatted as: BTC_GB7ZHXCNHG5IMEHIS2MG54DR3QJIPAQIBFBKZDMCHSDLJYNJNZXKS4SO_credit_alphanum4 The experimental ingestion system used a format of: BTC:GB7ZHXCNHG5IMEHIS2MG54DR3QJIPAQIBFBKZDMCHSDLJYNJNZXKS4SO
bartekn
approved these changes
Nov 15, 2019
This was referenced Nov 15, 2019
bartekn
added a commit
that referenced
this pull request
Nov 15, 2019
Bumps `expingest.CurrentVersion` to recreate state due to a bug fixed in #1936. We need to reingest existing state due to a rules change connected to trust lines authorization.
abuiles
reviewed
Nov 15, 2019
| err := set.Add(xdr.TrustLineEntry{ | ||
| AccountId: xdr.MustAddress("GAOQJGUAB7NI7K7I62ORBXMN3J4SSWQUQ7FOEPSDJ322W2HMCNWPHXFB"), | ||
| Asset: xdr.MustNewCreditAsset("EUR", trustLineIssuer.Address()), | ||
| Balance: 1, |
There was a problem hiding this comment.
I think passing Flags: 0 instead of relying on the zero value could help making the test more explicit about the expectations and how the trustline entry should look like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
The experimental ingestion pipeline has a bug in that it counts unauthorized trustlines when computing asset stats. Only authorized trustlines should be included.
Another issue fixed in this PR is that the cursor for the new asset stats endpoint diverges from the existing asset stats endpoint
Close #1933
Why
The new asset stats endpoint should have identical semantics to the existing endpoint