Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/expingest: Fix signer update effects. #2375

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Mar 10, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Don't show signer update effect if weight didn't change (fix #2136).

Why

As described in #2136, we were shaowing a signer update effect even when the weight wasn't changing. This adds a check and if the weight changed, then include the effect, otherwise, skip it.

@cla-bot cla-bot bot added the cla: yes label Mar 10, 2020
@abuiles abuiles force-pushed the fix-signer-effects branch from 8ccaaf4 to 9c65fde Compare March 10, 2020 18:09
@abuiles abuiles requested review from bartekn and tamirms March 10, 2020 18:10
@abuiles abuiles merged commit ce43434 into stellar:master Mar 10, 2020
@abuiles abuiles deleted the fix-signer-effects branch March 10, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix operations effects when signer changes.
2 participants