Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/docker: Update verify-range to use 1.0.0 as base. #2427

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Mar 30, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Update verify-range to use Horizon 1.0.0 as the base. We'll use a special branch with ingestion related changes cherry-picked into it.

Fix #2389

Why

Now that we have 2 release of Horizon 1.0.0, we can move to Horizon 1.0.0 as the base. This will make easier testing since we can cherry-pick easily ingestion related changes into 1.0.0 than 0.24.0

Running this right now against our protocol-13 branch yields

docker run  -e BRANCH=protocol-13 -e FROM=5772543 -e TO=5772607 -e VERIFY_HISTORY=true  verify-range 
...
< 24792947824267266,24792947824267264,2,7,{"trustee": "GDI73WJ4SX7LOG3XZDJC3KCK6ED6E5NBYK2JUBQSPBCNNWEG3ZN7T75U", "trustor": "GC2BQYBXFOVPRDH35D5HT2AFVCDGXJM5YVTAF5THFSAISYOWAJQKRESK", "authorize": true, "asset_code": "XBT", "asset_type": "credit_alphanum4", "asset_issuer": "GDI73WJ4SX7LOG3XZDJC3KCK6ED6E5NBYK2JUBQSPBCNNWEG3ZN7T75U"},GDI73WJ4SX7LOG3XZDJC3KCK6ED6E5NBYK2JUBQSPBCNNWEG3ZN7T75U
---
> 24792947824267266,24792947824267264,2,7,{"trustee": "GDI73WJ4SX7LOG3XZDJC3KCK6ED6E5NBYK2JUBQSPBCNNWEG3ZN7T75U", "trustor": "GC2BQYBXFOVPRDH35D5HT2AFVCDGXJM5YVTAF5THFSAISYOWAJQKRESK", "authorize": true, "asset_code": "XBT", "asset_type": "credit_alphanum4", "asset_issuer": "GDI73WJ4SX7LOG3XZDJC3KCK6ED6E5NBYK2JUBQSPBCNNWEG3ZN7T75U", "authorize_to_maintain_liabilities": true},GDI73WJ4SX7LOG3XZDJC3KCK6ED6E5NBYK2JUBQSPBCNNWEG3ZN7T75U

Which is correct since we haven't cherry-picked changes in ingestion yet.

Known limitations

[TODO or N/A]

@cla-bot cla-bot bot added the cla: yes label Mar 30, 2020
@abuiles abuiles marked this pull request as ready for review March 30, 2020 19:50
@abuiles abuiles force-pushed the verify-range-update-base branch from 113b26f to 391ba48 Compare March 30, 2020 19:50
@abuiles abuiles force-pushed the verify-range-update-base branch from 391ba48 to a310e4d Compare March 30, 2020 23:01
@abuiles abuiles merged commit afd6bb1 into stellar:master Mar 30, 2020
@abuiles abuiles deleted the verify-range-update-base branch March 30, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update verify-range docker image to use 1.0.0 as base
3 participants