Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Remove Core DB access from web, actions, and resourceadapters. #2677

Merged
merged 6 commits into from
Jun 8, 2020

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Jun 5, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Remove Core DB access from web, actions and resourceadapters.

Why

This is part of the work to drop db2/core (#2643) - I think these are the last changes we can do without requiring bigger structural changes to Horizon.

This PR was branch off #2675, so we need to land that one first before merging this one.

Known limitations

[TODO or N/A]

@cla-bot cla-bot bot added the cla: yes label Jun 5, 2020
@abuiles abuiles requested a review from a team June 5, 2020 20:43
@abuiles abuiles force-pushed the remove-db2-core branch from 5f5a8ec to 4180723 Compare June 8, 2020 15:27
@abuiles abuiles merged commit e08171f into stellar:master Jun 8, 2020
@abuiles abuiles deleted the remove-db2-core branch June 8, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants