Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Add transaction set operation count to history_ledger. #2690

Merged
merged 7 commits into from
Jun 16, 2020

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Jun 12, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Extend ingestion to store the total number of operations in the transaction set and expose it in the ledger resource via tx_set_operation_count.

Why

This feature was requested in #1385 and it will help us assess the used capacity of a transaction set.

With this change we have now the total count of operations in the transaction set and the number of successful operations.

Fix #1385.

Known limitations

[TODO or N/A]

@cla-bot cla-bot bot added the cla: yes label Jun 12, 2020
@abuiles abuiles requested review from a team and tomerweller June 12, 2020 22:40
@abuiles abuiles force-pushed the add-failed-op-count branch from 6492a4a to b27442d Compare June 12, 2020 22:58
@abuiles abuiles force-pushed the add-failed-op-count branch from b27442d to 576c244 Compare June 12, 2020 23:14
@abuiles abuiles added this to the Horizon 1.5.0 milestone Jun 15, 2020
Copy link
Contributor

@bartekn bartekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGELOG.

@abuiles abuiles changed the base branch from master to release-horizon-v1.5.0 June 16, 2020 17:58
@abuiles
Copy link
Contributor Author

abuiles commented Jun 16, 2020

@bartekn done and updated the base branch to 1.5 release.

@abuiles abuiles merged commit dce848d into stellar:release-horizon-v1.5.0 Jun 16, 2020
@abuiles abuiles deleted the add-failed-op-count branch June 16, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add failed operation count to ledger resource
2 participants