Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/expingest: Fix logging in OrderBookStream #2699

Merged

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Jun 17, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

When ingestion state is not consistent with ingestion history the OrderBookStream emits "ingestion state is invalid" log messages using the warn log level. This message should only be logged if the ingestion state is invalid. When history is not consistent with state we still can log a message but it should be logged using the info level.

@cla-bot cla-bot bot added the cla: yes label Jun 17, 2020
@tamirms tamirms requested a review from bartekn June 17, 2020 11:37
@tamirms tamirms merged commit c157ce9 into stellar:release-horizon-v1.5.0 Jun 17, 2020
@tamirms tamirms deleted the order-book-stream-log branch June 17, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants