Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Remove ingest failed transactions flag #2702

Merged

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Jun 17, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Remove ingest failed transactions flag so that Horizon will always ingest failed transactions

Why

Having failed transactions in the Horizon DB is useful because it allows us to remove the last remaining dependency on the stellar core DB in the txsub module.

Known limitations

There might be some operators who prefer to save space by not ingesting failed transactions in the Horizon DB. However, there is a reap system in Horizon which allows you to remove older rows in the history tables. Using horizon reap should satisfy the same need.

@cla-bot cla-bot bot added the cla: yes label Jun 17, 2020
@tamirms tamirms changed the title services/horizonRemove ingest failed transactions flag services/horizon: Remove ingest failed transactions flag Jun 17, 2020
@tamirms tamirms force-pushed the always-ingest-failed-tx branch 5 times, most recently from ff468ef to 4a2b798 Compare June 17, 2020 15:11
@tamirms tamirms force-pushed the always-ingest-failed-tx branch from 4a2b798 to 34c1541 Compare June 17, 2020 15:22
@tamirms tamirms force-pushed the always-ingest-failed-tx branch from b31dc86 to 0aa3e6a Compare June 17, 2020 15:45
@tamirms tamirms requested a review from a team June 17, 2020 16:10
Copy link
Contributor

@bartekn bartekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wonder if we should makes sure that users who use Horizon DB directly (which is not recommended!) know what is the result of this change. Added a suggestion..

services/horizon/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Bartek Nowotarski <bartek@nowotarski.info>
}

var _ txsub.ResultProvider = &DB{}

// ResultByHash implements txsub.ResultProvider
func (rp *DB) ResultByHash(ctx context.Context, hash string) txsub.Result {
historyLatest := ledger.CurrentState().HistoryLatest

// query history database
var hr history.Transaction
err := rp.History.TransactionByHash(&hr, hash)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamirms do we allow tx submission if Horizon is catching up with stellar-core? could this potentially cause a hash not to be found (since it hasn't been ingested)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good point. I think this issue you've spotted was already there before this PR so we can try to tackle it in another PR

@tamirms tamirms merged commit 776aa42 into stellar:release-horizon-v1.5.0 Jun 18, 2020
@tamirms tamirms deleted the always-ingest-failed-tx branch June 18, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants