services/horizon/cmd: Fix db-url flag parsing in horizon db commands #3192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Close #3191
The
horizon db migrate
andhorizon db init
commands share thedb-url
command line parameter with the horizon service flags defined in services/horizon/cmd/root.go. The horizon service flags are also initialized in root.go:To parse the
db-url
param in the migrate and init commands, we need to callflag.Require()
andflag.SetValue()
.The reason why this code wasn't working before is because we were calling on
Require()
andSetValue()
ondbURLConfigOption
which was never initialized against any of the db commands or the root command.Known limitations
[N/A]