Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Add latest ledger closed_at metrics #3281

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Dec 15, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This commit adds:

  • history_latest_ledger_closed_at to root resource that determines the latest ingested ledger close time,
  • horizon_history_latest_ledger_closed_ago_seconds to /metrics that return time in seconds since the latest ingested ledger close time.

Close #3206.

Why

core_latest_ledger - history_latest_ledger doesn't always determine if Horizon is fully sync with the network. It's possible that underlying Core instance is behind or stuck.

@bartekn bartekn requested a review from a team December 15, 2020 12:50
@cla-bot cla-bot bot added the cla: yes label Dec 15, 2020
@bartekn bartekn merged commit f1b656a into stellar:master Dec 16, 2020
@bartekn bartekn deleted the ledger_closed_ago_metric branch December 16, 2020 21:22
bartekn added a commit to bartekn/go that referenced this pull request Jan 6, 2021
This commit adds:
* `history_latest_ledger_closed_at` to root resource that determines the
latest ingested ledger close time,
* `horizon_history_latest_ledger_closed_ago_seconds` to `/metrics` that
return time in seconds since the latest ingested ledger close time.

`core_latest_ledger - history_latest_ledger` doesn't always determine if
Horizon is fully sync with the network. It's possible that underlying
Core instance is behind or stuck.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add last_ledger_closed_ago_seconds to metrics and root endpoint
2 participants