ingest: Use a *random* history archive from the Captive Core configuration list #3375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Introduces
historyarchive.ConnectAny
, which chooses a random history archive from a list of URLs until succeeding.Why
Previously, listing more than one history archive in the Captive Core configuration had no impact since the first was always used. This is (more or less) a preliminary effort into being smarter about the way we use history archives.
Moving forward, the goal may be to refactor the
historyarchive
library to use a random archive for every request for redundancy purposes, but this can be done in future PRs.Known limitations
I'd like to add a test.