historyarchive: Introduce a History Archive pool that's selected from for all calls #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
reviewed
Feb 11, 2021
tamirms
reviewed
Feb 11, 2021
bartekn
reviewed
Feb 11, 2021
historyarchive/pool.go
Outdated
Comment on lines
1
to
4
| // Copyright 2016 Stellar Development Foundation and contributors. Licensed | ||
| // under the Apache License, Version 2.0. See the COPYING file at the root | ||
| // of this distribution or at http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
There was a problem hiding this comment.
I don't think we need copyright comment on top of this file. At least we don't have it in most of other files. @ire-and-curses?
Suggested change
| // Copyright 2016 Stellar Development Foundation and contributors. Licensed | |
| // under the Apache License, Version 2.0. See the COPYING file at the root | |
| // of this distribution or at http://www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
Re: copyright - let's just follow whatever we do everywhere else in the codebase.
There was a problem hiding this comment.
Yeah so I was confused by this, too. In the historyarchive package, all of the files have copyright notices. The years are mixed, but all of them have one. So I added it here.
tamirms
reviewed
Feb 12, 2021
I don't understand Golang *super* well yet, but I think that methods on a *Type are way less restrictive than methods on a Type, right?
tamirms
reviewed
Feb 16, 2021
tamirms
approved these changes
Feb 16, 2021
tamirms
approved these changes
Feb 16, 2021
This was referenced Feb 16, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This is an improvement over #3375 which just chooses a random URL from the list. Instead, we should actually create a pool of all history archive connections and cycle through them randomly for each HA-related operation we need.
Why
With this change, we actually use the entire URL list in the configuration that the user provides. This adds resilience and redundancy. See stellar/horizon-internal#3 for more context.
Known limitations
n/a