services/horizon: Allow customization of the Captive Core log file. #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, we either log to Horizon's subservice=stellar-core or we pass along to Stellar-Core's LOG_FILE_PATH="..." based on the value of the above parameter.
tamirms
reviewed
Mar 18, 2021
bartekn
reviewed
Mar 18, 2021
Shaptic
commented
Mar 18, 2021
Comment on lines
72
to
77
| CaptiveCoreBinaryPath: app.config.CaptiveCoreBinaryPath, | ||
| CaptiveCoreConfigAppendPath: app.config.CaptiveCoreConfigAppendPath, | ||
| CaptiveCoreHTTPPort: app.config.CaptiveCoreHTTPPort, | ||
| CaptiveCoreLogPath: app.config.CaptiveCoreLogPath, | ||
| RemoteCaptiveCoreURL: app.config.RemoteCaptiveCoreURL, | ||
| EnableCaptiveCore: app.config.EnableCaptiveCoreIngestion, |
There was a problem hiding this comment.
As an informational question, why do we do this, rather than passing along app.config directly?
There was a problem hiding this comment.
It's clear which global config variables are used by the component. I know that we sometimes pass entire config in other places in Horizon but I believe we should only pass specific values.
bartekn
approved these changes
Mar 18, 2021
Comment on lines
72
to
77
| CaptiveCoreBinaryPath: app.config.CaptiveCoreBinaryPath, | ||
| CaptiveCoreConfigAppendPath: app.config.CaptiveCoreConfigAppendPath, | ||
| CaptiveCoreHTTPPort: app.config.CaptiveCoreHTTPPort, | ||
| CaptiveCoreLogPath: app.config.CaptiveCoreLogPath, | ||
| RemoteCaptiveCoreURL: app.config.RemoteCaptiveCoreURL, | ||
| EnableCaptiveCore: app.config.EnableCaptiveCoreIngestion, |
There was a problem hiding this comment.
It's clear which global config variables are used by the component. I know that we sometimes pass entire config in other places in Horizon but I believe we should only pass specific values.
Co-authored-by: Bartek Nowotarski <bartek@nowotarski.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This introduces the
--captive-core-log-pathparameter, which sets Stellar Core'sLOG_FILE_PATHin the auto-generated configuration accordingly. If it's not set, Horizon will continue to log Captive Core's output to its log path withsubservice=stellar-core.Why
Closes #3438
Known limitations
n/a