services/horizon: Issue #3476, Include claimable balances in asset stats summaries #3502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add tests
7 tasks
added 2 commits
March 26, 2021 18:35
tamirms
reviewed
Mar 26, 2021
services/horizon/internal/ingest/processors/asset_stats_processor.go
Outdated
Show resolved
Hide resolved
bartekn
approved these changes
Mar 31, 2021
services/horizon/internal/docs/reference/endpoints/assets-all.md
Outdated
Show resolved
Hide resolved
services/horizon/internal/ingest/processors/asset_stats_processor.go
Outdated
Show resolved
Hide resolved
services/horizon/internal/ingest/processors/asset_stats_processor.go
Outdated
Show resolved
Hide resolved
2opremio
reviewed
Mar 31, 2021
| Unauthorized: a.Unauthorized + b.Unauthorized, | ||
| } | ||
| } | ||
|
|
||
| func (a ExpAssetStatAccounts) IsZero() bool { | ||
| return a.Authorized == 0 && a.AuthorizedToMaintainLiabilities == 0 && a.Unauthorized == 0 | ||
| return a == ExpAssetStatAccounts{} |
There was a problem hiding this comment.
Unrelated to this PR: does Exp stand for experimental? If so, I think it's about time to remove it.
There was a problem hiding this comment.
It seems like db2 and history are both misnomers as well, given there's only one db, and two "sections" (for lack of a better term) within it, the normal (current? state?) tables and history_* tables.
There was a problem hiding this comment.
Maybe we should try to change exp_asset_stats table name too? Not sure how complicated it is.
Co-authored-by: Bartek Nowotarski <bartek@nowotarski.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Fixes #3476.
Add
accounts.claimable_balances, andbalances.claimable_balancessummary fields to/assets.Why
See: #3476
Known limitations
[TODO or N/A]