horizon: Test consistency and coverage of effect typenames (and cleanup unused effects) #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
3430-test-coverage-of-effect-switches
branch
from
2d3920b to
618d917
Compare
tamirms
approved these changes
Apr 26, 2021
bartekn
reviewed
Apr 26, 2021
protocols/horizon/effects/main.go
Outdated
| // EffectAccountInflationDestinationUpdated effects occur when an account changes its | ||
| // inflation destination. | ||
| EffectAccountInflationDestinationUpdated EffectType = 7 // from set_options | ||
| // EffectAccountInflationDestinationUpdated EffectType = 7 // from set_options |
There was a problem hiding this comment.
It looks like Horizon is producing it here:
go/services/horizon/internal/ingest/processors/effects_processor.go
Lines 567 to 573 in f362e0c
I think it's worth keeping the value here.
There was a problem hiding this comment.
Really good catch, thanks @bartekn
2opremio
force-pushed
the
3430-test-coverage-of-effect-switches
branch
from
618d917 to
483a690
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3430