services/horizon: Add 1s timeout to horizon.App.Tick #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
reviewed
Apr 23, 2021
tamirms
approved these changes
Apr 24, 2021
bartekn
approved these changes
Apr 26, 2021
7 tasks
7 tasks
bartekn
added a commit
that referenced
this pull request
Jul 23, 2021
This commit moves ledger reaping service outside global `Tick()` method. After #3567 reap process was cancelled after 1s. However in some deployments removing older ledgers take more time. To prevent the process from being cancelled in `Tick` it was moved outside of this method to a separate service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3344
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Add 1s timeout to total runtime of
horizon.App.Tick.Why
See #3344
Known limitations
Just a single timeout, not per-item. But that seems to make sense given we want them all to complete within 1s total.