Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdr: Easily created MuxedAccount objects from a G-address and a memo ID. #3677

Merged
merged 10 commits into from
Jun 25, 2021

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Jun 8, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Introduces MuxedAccountFromAccountId, which makes it easy to turn an account ID (G...) into a full MuxedAccount with a memo ID (i.e. representing an M... address). Also introduces MuxedAccount.GetId(), making it easy to extract the underlying memo ID if it's present.

Why

If you have a G-address, it should be easy to create M-addresses from it.

Known limitations

n/a

@Shaptic Shaptic requested a review from a team June 15, 2021 00:00
xdr/muxed_account.go Outdated Show resolved Hide resolved
@Shaptic Shaptic force-pushed the easy-muxed-accounts branch from 2b51e96 to ccd914d Compare June 15, 2021 18:29
@Shaptic Shaptic requested a review from bartekn June 15, 2021 18:34
xdr/muxed_account.go Outdated Show resolved Hide resolved
@bartekn
Copy link
Contributor

bartekn commented Jun 25, 2021

It would be super helpful for me when writing tests for #3722. Please merge.

@Shaptic Shaptic merged commit b0d7b1e into stellar:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants