Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stellar-core to stellar/stellar-horizon image #4019

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

2opremio
Copy link
Contributor

Also:

  • Add default versions for Horizon and Core
  • Use ENTRYPOINT instead of CMD (otherwise docker run subcommand
    doesn't result in a horizon subcommand being run)

Closes #4006

@2opremio 2opremio requested review from jacekn and a team October 20, 2021 12:54
services/horizon/docker/Dockerfile Show resolved Hide resolved
services/horizon/docker/Dockerfile Outdated Show resolved Hide resolved
services/horizon/docker/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@jacekn jacekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few small comments but in principal it looks good.

Also:
* Add default versions for Horizon and Core
* Use ENTRYPOINT instead of CMD (otherwise `docker run subcommand`
  doesn't result in a horizon subcommand being run)
@2opremio
Copy link
Contributor Author

@jacekn PTAL

@2opremio 2opremio force-pushed the 4006-add-stellar-core-to-docker branch from 2d02508 to dc85d78 Compare October 25, 2021 16:07
Copy link
Contributor

@jacekn jacekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement

@2opremio 2opremio merged commit 95d3084 into stellar:master Oct 25, 2021
@2opremio 2opremio deleted the 4006-add-stellar-core-to-docker branch October 25, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stellar/stellar-horizon docker image should use Captive-Core
3 participants