services/horizon: Implement horizon db fill-gaps command #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekn
reviewed
Nov 9, 2021
Co-authored-by: Bartek Nowotarski <bartek@nowotarski.info>
Co-authored-by: Bartek Nowotarski <bartek@nowotarski.info>
|
@bartekn can you take another look? |
bartekn
approved these changes
Nov 9, 2021
7 tasks
tamirms
added a commit
that referenced
this pull request
Dec 6, 2021
…llel-workers (#4127) #4060 introduced a bug where command line flags such as --parallel-workers are not getting parsed when running the horizon db reingest range command. This commit fixes this bug so that all the reingest range command line flags are parsed correctly for both the reingest range command and the fill-gaps command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Close #4010
horizon db fill-gapscan be called with no parameters in which case it queries for any existing gaps in the horizon db and then proceeds to ingest history to fill the gaps.The command can also be called with a start and end ledger parameter. In which case, the command will only query for gaps within the provided range.
horizon db fill-gaps 1 1000will fill any gaps occurring within the range 1-1000It is also possible to configure the same parallel worker command line parameters that are used by horizon db reingest range so that fill-gaps can be also take advantage of concurrency.
Known limitations
[N/A]