services/horizon/internal/db2/history: Include lower bound on descending history queries #5465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
CHANGELOG.md
within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Include a lower bound on queries for the history endpoints which fetch rows in descending order. The following endpoints have been modified to include the lower bound:
/transactions
/ledgers
/effects
/operations
/trades
Why
In the case where a lot of history has been reaped when running a horizon instance with limited history, there will be a large amount of rows which will be deleted from the history tables. These rows will still be present in Postgres until they get vacuumed at which point they will be removed from the tables and indexes.
So, for example, if you query for transactions in sorted order, postgres will be need to sift through and discard rows which have been deleted. This can result in the query timing out if there is a large amount of deleted rows in the search. We can avoid having to sift through deleted rows by including a lower bound beyond which there should be no deleted rows. We can use the oldest ledger in the horizon db as the lower bound.
Known limitations
[N/A]