Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SEP0029 support for FeeBumpTransaction. #535

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Apr 27, 2020

Handle SEP0029 memo required check when sending a FeeBumpTransaction.

@@ -701,7 +707,13 @@ export class Server {
* requires a memo, the promise will throw {@link AccountRequiresMemoError}.
* @throws {AccountRequiresMemoError}
*/
public async checkMemoRequired(transaction: Transaction): Promise<void> {
public async checkMemoRequired(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abuiles, if the operation destination is an M.. address, can Horizon load it correctly? Or should we skip this single check?

https://github.com/stellar/js-stellar-sdk/pull/535/files#diff-916156c481141bfcd08c6ae40ce10e00R742

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@overcat that's a great question, I believe we should skip the check if the destination is an M address since M addresses essentially encode a memo within them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@overcat good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants