Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-cli: move config * commands to top level #1054

Closed
leighmcculloch opened this issue Oct 26, 2023 · 1 comment · Fixed by #1086
Closed

soroban-cli: move config * commands to top level #1054

leighmcculloch opened this issue Oct 26, 2023 · 1 comment · Fixed by #1086
Assignees
Labels
cli Related to Soroban CLI

Comments

@leighmcculloch
Copy link
Member

I think we should consider moving the commands that live under soroban config to the top level.

i.e.:

config identity => key (assuming #1053)
config network => network

The network and identity commands are buried under config which makes them hard to find. They're important concepts that devs need to access regularly.

We should bury things under config if they're a set once and forget type of thing.

In reality devs need to interact with keys frequently. And likely need to switch and use multiple networks frequently too.

@willemneal
Copy link
Member

True, the subcommand doesn't add much value, and soon we'll need a network start which definitely should be at the top level.

@mollykarcher mollykarcher moved this from Backlog to Needs Review in Platform Scrum Dec 14, 2023
@mollykarcher mollykarcher moved this from Needs Review to In Progress in Platform Scrum Dec 14, 2023
@mollykarcher mollykarcher added the cli Related to Soroban CLI label Dec 14, 2023
@mollykarcher mollykarcher moved this from In Progress to Blocked in Platform Scrum Dec 14, 2023
@mollykarcher mollykarcher moved this from Blocked to In Progress in Platform Scrum Jan 4, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Platform Scrum Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to Soroban CLI
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants