Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tx auth command #1493

Open
Ifropc opened this issue Jul 26, 2024 · 1 comment
Open

Add a tx auth command #1493

Ifropc opened this issue Jul 26, 2024 · 1 comment
Assignees

Comments

@Ifropc
Copy link
Contributor

Ifropc commented Jul 26, 2024

There are some functionalities related to auths that we were considering adding to different commands, but IMO it could get a bit clunky to find those subcommands or flags, instead adding a new command sounds like a more clear user story.
Currently, I can see 2 primarily functionalities that we wanted to add, related to auths:

  1. Signing auths (originally part of feat: add tx sign/send and Stellar trait #1406)
    While it makes sense to add a new flag (--auth-only) to sign, moving it to a new command makes more sense it we want tx sign to have the same flags as other transaction signing commands. Moreover, not all transactions may have auth entries inside (in fact, most will not).
    As such, we can add tx auth <xdr> --sign-with-* command that only sings auths.
  2. --dry-run for signing auths (Add a --dry-run option to tx sign #1486) nicely follows in line with ^
  3. auth show <xdr> would be a great subcommand that lists all auths in this transaction, and shows which one is signed, which are not signed

cc @janewang @willemneal @leighmcculloch

@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Jul 26, 2024
@Ifropc Ifropc moved this from Backlog (Not Ready) to Todo (Ready for Dev) in DevX Jul 30, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This issue is stale because it has been assigned for 30 days with no activity. It will be closed in 30 days unless the stale label is removed, and the assignee is removed or updated.

@github-actions github-actions bot added the stale label Dec 4, 2024
@fnando fnando removed the stale label Dec 4, 2024
@willemneal willemneal assigned willemneal and unassigned willemneal Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo (Ready for Dev)
Development

No branches or pull requests

3 participants