fix(CLI): fund command now can accept a public strkey #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsachiherman
approved these changes
Oct 16, 2023
willemneal
added a commit
to AhaLabs/stellar-cli
that referenced
this pull request
Oct 20, 2023
fixes stellar#1014 Co-authored-by: Tsachi Herman <24438559+tsachiherman@users.noreply.github.com>
willemneal
added a commit
to AhaLabs/stellar-cli
that referenced
this pull request
Oct 20, 2023
fixes stellar#1014 Co-authored-by: Tsachi Herman <24438559+tsachiherman@users.noreply.github.com>
tsachiherman
added a commit
that referenced
this pull request
Oct 20, 2023
* Feat!(CLI): remove sandbox (#997) * feat!: remove run_in_sandbox * fix: reorganize tests that rely on network and ignore outside of go test * fix: use feature instead of cfg so that cargo test --list can find tests * fix: move common tests to single functions to skip setup time * feat!: skip wasm in invoke * fix: fully remove all sandbox related types and args * fix: clippy --all (#1013) * fix: clippy and git-hooks * fix: split CLI tests and normal go tests so they can run concurrently * fix(CLI): fund command now can accept a public strkey (#1020) fixes #1014 Co-authored-by: Tsachi Herman <24438559+tsachiherman@users.noreply.github.com> --------- Co-authored-by: Tsachi Herman <24438559+tsachiherman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
fixes #1014
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]