Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: preflight: enable debug by default now that there is a debug budget #1064

Merged
merged 1 commit into from
Nov 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/soroban-rpc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ jobs:
env:
SOROBAN_RPC_INTEGRATION_TESTS_ENABLED: true
SOROBAN_RPC_INTEGRATION_TESTS_CAPTIVE_CORE_BIN: /usr/bin/stellar-core
PROTOCOL_20_CORE_DEBIAN_PKG_VERSION: 19.14.1-1529.fcbbad4ce.focal
PROTOCOL_20_CORE_DEBIAN_PKG_VERSION: 19.14.1-1547.f2d06fbce.focal
steps:
- uses: actions/checkout@v3
with:
Expand Down
43 changes: 22 additions & 21 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,18 @@ version = "20.0.0-rc4"
[workspace.dependencies.soroban-env-host]
version = "20.0.0-rc2"
git = "https://github.com/stellar/rs-soroban-env"
rev = "91f44778389490ad863d61a8a90ac9875ba6d8fd"
rev = "2674d867d7c6aa4212abab05ff30e5804ff1db90"

[workspace.dependencies.soroban-spec]
version = "20.0.0-rc2"
git = "https://github.com/stellar/rs-soroban-sdk"
rev = "729ed3ac5fe8600a3245d5816eadd3c95ab2eb54"
rev = "fb422beae0d4944dc0e83559a8940b31f5ebd89d"
# path = "../rs-soroban-sdk/soroban-spec"

[workspace.dependencies.soroban-spec-rust]
version = "20.0.0-rc2"
git = "https://github.com/stellar/rs-soroban-sdk"
rev = "729ed3ac5fe8600a3245d5816eadd3c95ab2eb54"
rev = "fb422beae0d4944dc0e83559a8940b31f5ebd89d"
# path = "../rs-soroban-sdk/soroban-spec-rust"

[workspace.dependencies.soroban-spec-json]
Expand All @@ -45,12 +45,12 @@ path = "./cmd/crates/soroban-spec-tools"
[workspace.dependencies.soroban-sdk]
version = "20.0.0-rc2"
git = "https://github.com/stellar/rs-soroban-sdk"
rev = "729ed3ac5fe8600a3245d5816eadd3c95ab2eb54"
rev = "fb422beae0d4944dc0e83559a8940b31f5ebd89d"

[workspace.dependencies.soroban-ledger-snapshot]
version = "20.0.0-rc2"
git = "https://github.com/stellar/rs-soroban-sdk"
rev = "729ed3ac5fe8600a3245d5816eadd3c95ab2eb54"
rev = "fb422beae0d4944dc0e83559a8940b31f5ebd89d"

[workspace.dependencies.soroban-cli]
version = "20.0.0-rc4"
Expand Down
2 changes: 1 addition & 1 deletion cmd/soroban-rpc/internal/config/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ func (cfg *Config) options() ConfigOptions {
Name: "preflight-enable-debug",
Usage: "Enable debug information in preflighting (provides more detailed errors). It should not be enabled in production deployments.",
ConfigKey: &cfg.PreflightEnableDebug,
DefaultValue: false,
DefaultValue: true,
},
{
TomlKey: strutils.KebabToConstantCase("request-backlog-global-queue-limit"),
Expand Down
2 changes: 1 addition & 1 deletion cmd/soroban-rpc/internal/test/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ services:
# Note: Please keep the image pinned to an immutable tag matching the Captive Core version.
# This avoids implicit updates which break compatibility between
# the Core container and captive core.
image: ${CORE_IMAGE:-2opremio/stellar-core:19.14.1-1529.fcbbad4ce.focal}
image: ${CORE_IMAGE:-stellar/stellar-core:19.14.1-1547.f2d06fbce.focal}
depends_on:
- core-postgres
restart: on-failure
Expand Down
2 changes: 1 addition & 1 deletion cmd/soroban-rpc/lib/preflight/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ base64 = { workspace = true }
thiserror = { workspace = true }
libc = "0.2.147"
sha2 = { workspace = true }
soroban-env-host = { workspace = true }
soroban-env-host = { workspace = true, features = ["recording_auth"]}
rand = "0.8.5"
Loading