Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add long list for identities #1096

Closed

Conversation

elizabethengelman
Copy link
Contributor

@elizabethengelman elizabethengelman commented Nov 22, 2023

What

Adding a --long flag to soroban config identity ls, similar to soroban config network ls --long to print out the paths to identity configuration files.

Why

This was originally added in a previous PR (#743) and was removed at some point - presumably unintentionally. This seems like a helpful addition to help users understand where their identities are being configured.

Example output:

$ soroban config identity ls --long
/Users/elizabethengelman/.config/soroban/identity/alice.toml
Name: alice

/Users/elizabethengelman/.config/soroban/identity/bob.toml
Name: bob

/Users/elizabethengelman/.config/soroban/identity/carol.toml
Name: carol

Known limitations

N/A

@elizabethengelman elizabethengelman changed the title Add long list for identity feat: add long list for identities Nov 22, 2023
@elizabethengelman elizabethengelman marked this pull request as ready for review November 22, 2023 20:09
@willemneal
Copy link
Member

Looks great! Could you retarget to the branch of this PR #1086 ?

After refactoring a bit to the new location I think it's good to go!

@elizabethengelman
Copy link
Contributor Author

Looks great! Could you retarget to the branch of this PR #1086 ?

Sure thing!

@elizabethengelman elizabethengelman force-pushed the add-long-list-for-identity branch from 02880bb to aed6a8f Compare November 22, 2023 20:46
@elizabethengelman
Copy link
Contributor Author

@willemneal I wasn't able to re-target the base branch directly on this PR, so I'm closing this in favor of AhaLabs#18

@elizabethengelman elizabethengelman deleted the add-long-list-for-identity branch February 26, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants