Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/network container improvements #1423

Merged
merged 38 commits into from
Jul 22, 2024
Merged

Fix/network container improvements #1423

merged 38 commits into from
Jul 22, 2024

Commits on Jul 15, 2024

  1. Return a better error message when stopping container that doesn't exist

    @elizabethengelman
    elizabethengelman committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    d26eb22 View commit details
    Browse the repository at this point in the history

  2. Fix doc strings for network container commands

    @elizabethengelman
    elizabethengelman committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    321a48f View commit details
    Browse the repository at this point in the history

  3. Pull shared container args to shared.rs

    @elizabethengelman
    elizabethengelman committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ae4ea7f View commit details
    Browse the repository at this point in the history

  4. Allow for overwriting the default container name with -c

    @elizabethengelman
    elizabethengelman committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    5c67caf View commit details
    Browse the repository at this point in the history

  5. Check in generated doc updates

    @elizabethengelman
    elizabethengelman committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    70b6c39 View commit details
    Browse the repository at this point in the history

  6. Refactor printlns

    @elizabethengelman
    elizabethengelman committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    89bceec View commit details
    Browse the repository at this point in the history

  7. Clippy & cleanup errors

    @elizabethengelman
    elizabethengelman committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    d800be5 View commit details
    Browse the repository at this point in the history

  8. Rename ContainerArgs -> Args

    @elizabethengelman
    elizabethengelman committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    196c5e5 View commit details
    Browse the repository at this point in the history

  9. Update cmd/soroban-cli/src/commands/network/container/start.rs 

    Co-authored-by: Willem Wyndham <willem@ahalabs.dev>
    @elizabethengelman @willemneal
    elizabethengelman and willemneal authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    07ccbda View commit details
    Browse the repository at this point in the history

  10. Use expect instead of unwrap in get_container_name

    @elizabethengelman
    elizabethengelman committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    523adb2 View commit details
    Browse the repository at this point in the history

  11. Add get_additional_flags fn on Args to reduce duplication

    @elizabethengelman
    elizabethengelman committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    c81f788 View commit details
    Browse the repository at this point in the history

  12. Add get_container_name_arg fn on Args to reduce duplication

    @elizabethengelman
    elizabethengelman committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ce13f84 View commit details
    Browse the repository at this point in the history

  13. Apply suggestions from code review 

    Impl get_container_name in Args struct

Co-authored-by: Willem Wyndham <willem@ahalabs.dev>
    @elizabethengelman @willemneal
    elizabethengelman and willemneal committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    2a16a42 View commit details
    Browse the repository at this point in the history

  14. Add a comment explaining get_container_name_arg

    @elizabethengelman
    elizabethengelman committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    8704b32 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Clean up doc comments

    @elizabethengelman
    elizabethengelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    479fb13 View commit details
    Browse the repository at this point in the history

  2. Simplify stop and logs commmands 

    Instead of allowing these commands to take in either --network or
--container_name this commit change these commands to just require the
name of the container <NAME>

This commit also renames the container_name args to name
    @elizabethengelman
    elizabethengelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    305c281 View commit details
    Browse the repository at this point in the history

  3. Update the docs

    @elizabethengelman
    elizabethengelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2f17a58 View commit details
    Browse the repository at this point in the history

  4. Revert "Simplify stop and logs commmands" 

    This reverts commit d21365a.
    @elizabethengelman
    elizabethengelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    299e036 View commit details
    Browse the repository at this point in the history

  5. Rename container_name arg to name

    @elizabethengelman
    elizabethengelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c2670e2 View commit details
    Browse the repository at this point in the history

  6. Update help docs

    @elizabethengelman
    elizabethengelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a9fa5b0 View commit details
    Browse the repository at this point in the history

  7. Clippy

    @elizabethengelman
    elizabethengelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    aac2440 View commit details
    Browse the repository at this point in the history

  8. Move connect_to_docker to Arg impl

    @elizabethengelman
    elizabethengelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3ed3586 View commit details
    Browse the repository at this point in the history

  9. Refactor start command: move helper fns to Cmd impl

    @elizabethengelman
    elizabethengelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    fcb28dc View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into fix/network-container-improvements

    @elizabethengelman
    elizabethengelman authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    33b51bd View commit details
    Browse the repository at this point in the history

  11. Default container name to network name 

    instead of prepending it with
stellar. This will simplify logs and stop commands.
    @elizabethengelman
    elizabethengelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e997527 View commit details
    Browse the repository at this point in the history

  12. Update stop and logs commands to accept the container name 

    instead of the network.
    @elizabethengelman
    elizabethengelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    aadfc63 View commit details
    Browse the repository at this point in the history

  13. Update docs

    @elizabethengelman
    elizabethengelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e96b8e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Merge branch 'main' into fix/network-container-improvements

    @elizabethengelman
    elizabethengelman authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    a18ac18 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/network-container-improvements

    @elizabethengelman
    elizabethengelman authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f79b59d View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Create a Name type to handle internal vs external name conventions

    @elizabethengelman
    elizabethengelman committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    0c95562 View commit details
    Browse the repository at this point in the history

  2. Prefix container names with 'stellar-'

    @elizabethengelman
    elizabethengelman committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    235f521 View commit details
    Browse the repository at this point in the history

  3. Add tests for Name struct

    @elizabethengelman
    elizabethengelman committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    03d29ac View commit details
    Browse the repository at this point in the history

  4. Refactor Name fns

    @elizabethengelman
    elizabethengelman committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    392e1f6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into fix/network-container-improvements

    @elizabethengelman
    elizabethengelman authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    42a9bfc View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into fix/network-container-improvements

    @elizabethengelman
    elizabethengelman authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    6fbb3f3 View commit details
    Browse the repository at this point in the history

  7. Update Name::new to just take in one arg 

    Co-authored-by: Willem Wyndham <willem@ahalabs.dev>
    @elizabethengelman @willemneal
    elizabethengelman and willemneal committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ec3d39f View commit details
    Browse the repository at this point in the history

  8. Refactor Name

    @elizabethengelman
    elizabethengelman committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    996dea4 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into fix/network-container-improvements

    @elizabethengelman
    elizabethengelman authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    c7c465c View commit details
    Browse the repository at this point in the history