-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soroban-rpc: Add getPreflight benchmark and test #692
soroban-rpc: Add getPreflight benchmark and test #692
Conversation
In the current benchmark (which simulates a hello world contract with in-memory ledger entries) I get:
That is, I should now write a test accessing the DB. |
b21e6f8
to
d3f45b0
Compare
f1b14c3
to
c117697
Compare
c117697
to
c8a46f0
Compare
I have added a benchmark using the DB and there is a considerable difference:
This indicates we should probably be caching the config entries with a write-through cache. |
note that the benchmark indicates that, even without caching, the preflight took 0.5 ms vs 0.2 milliseconds. So maybe it's not worth the optimization after all |
@tsachiherman PTAL |
No description provided.