-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soroban-rpc: Stream ledgers on initialization #904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This halves the startup ledger memory requirements (since we don't no longer need to store all the ledgers in memory before initializing the stores).
2opremio
force-pushed
the
stream-ledgers-on-init
branch
from
August 28, 2023 17:07
8d7e52b
to
4b50487
Compare
tsachiherman
suggested changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that I found few small issues.
tamirms
reviewed
Aug 28, 2023
tamirms
reviewed
Aug 28, 2023
tsachiherman
approved these changes
Aug 28, 2023
sreuland
approved these changes
Aug 28, 2023
2opremio
force-pushed
the
stream-ledgers-on-init
branch
from
August 28, 2023 22:46
d116e79
to
1eaeb86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This halves the startup ledger memory requirements (since we don't no longer need to store all the ledgers in memory before initializing the stores).
Addresses part of #554