Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc: Stream ledgers on initialization #904

Merged
merged 4 commits into from
Aug 28, 2023

Conversation

2opremio
Copy link
Contributor

This halves the startup ledger memory requirements (since we don't no longer need to store all the ledgers in memory before initializing the stores).

Addresses part of #554

This halves the startup ledger memory requirements (since we don't no longer
need to store all the ledgers in memory before initializing the stores).
@2opremio 2opremio force-pushed the stream-ledgers-on-init branch from 8d7e52b to 4b50487 Compare August 28, 2023 17:07
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that I found few small issues.

cmd/soroban-rpc/internal/db/ledger.go Outdated Show resolved Hide resolved
cmd/soroban-rpc/internal/daemon/daemon.go Outdated Show resolved Hide resolved
@2opremio 2opremio force-pushed the stream-ledgers-on-init branch from d116e79 to 1eaeb86 Compare August 28, 2023 22:46
@2opremio 2opremio enabled auto-merge (squash) August 28, 2023 23:13
@2opremio 2opremio merged commit 0d3fbcb into stellar:main Aug 28, 2023
19 of 20 checks passed
@2opremio 2opremio deleted the stream-ledgers-on-init branch August 28, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants