soroban-rpc: Validate xdr payloads in soroban-rpc requests #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
force-pushed
the
validate-xdr-requests
branch
from
0f68f0e to
90c9dae
Compare
2opremio
approved these changes
Sep 13, 2023
| Infof("could not validate ledgerKey at index %d from getLedgerEntries request", i) | ||
| return GetLedgerEntriesResponse{}, &jrpc2.Error{ | ||
| Code: jrpc2.InvalidParams, | ||
| Message: fmt.Sprintf("cannot unmarshal key value %s at index %d", requestKey, i), |
There was a problem hiding this comment.
I'm not sure that we should duplicate the ledger key in the response. The caller should know what's the "third" or "fifth" ledger key they sent in the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Validate xdr payloads in soroban-rpc requests.
Known limitations
[N/A]