Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BucketListDB on Validators by Default #3811

Closed
7 of 9 tasks
SirTyson opened this issue Jul 5, 2023 · 1 comment
Closed
7 of 9 tasks

Enable BucketListDB on Validators by Default #3811

SirTyson opened this issue Jul 5, 2023 · 1 comment
Assignees

Comments

@SirTyson
Copy link
Contributor

SirTyson commented Jul 5, 2023

Currently, BucketListDB is enabled and running by default in captive-core, but is still disabled by default in validators. While BucketListDB has been running without issue in captive-core, we are holding off on enabling BucketListDB until after Soroban launch on mainnet. BucketListDB has only run on Stellar Classic in production captive-core instances and we want to wait and make sure it works well on Soroban entries before enabling it by default. We will watch how captive-core handles Soroban and enable it after launch.

Currently, captive-core supports persisting indexes on disk, but validators do not. This is due to a bug found during development where loading a persistent index resulted in a corrupted index, causing the DB to load data incorrectly. Because of this issue, validators do not persist indexes. Before enabling BucketListDB for validators, we should resolve #3677 and add safety checks so that validators can persist indexes. After resolving this issue and seeing how captive-core handles Soroban, we should enable BucketListDB.

This is not a pressing issue for now since network performance is not disk bound, but is more of a future-proofing measure and a helpful startup performance increase.

Tasks

  1. SirTyson
  2. SirTyson
  3. enhancement
    SirTyson
  4. bug
    SirTyson
@SirTyson SirTyson self-assigned this Jan 10, 2024
@anupsdf
Copy link
Contributor

anupsdf commented Apr 26, 2024

Closing this since we have already enabled BL DB in core validators.

@anupsdf anupsdf closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants