Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin 'concurrent-ruby' to a working version. #206

Merged

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Feb 4, 2025

See https://stackoverflow.com/questions/79360526/uninitialized-constant-activesupportloggerthreadsafelevellogger-nameerror

Running xdrgen will result in the following error, and this PR will fix the issue.

/usr/local/rvm/gems/default/gems/activesupport-6.1.6.1/lib/active_support/logger_thread_safe_level.rb:16:in `<module:LoggerThreadSafeLevel>': uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError)

    Logger::Severity.constants.each do |severity|
          ^^^^^^^^^^
        from /usr/local/rvm/gems/default/gems/activesupport-6.1.6.1/lib/active_support/logger_thread_safe_level.rb:9:in `<module:ActiveSupport>'
        from /usr/local/rvm/gems/default/gems/activesupport-6.1.6.1/lib/active_support/logger_thread_safe_level.rb:8:in `<top (required)>'
        from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
        from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
        from /usr/local/rvm/gems/default/gems/activesupport-6.1.6.1/lib/active_support/logger_silence.rb:5:in `<top (required)>'
        from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
        from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
        from /usr/local/rvm/gems/default/gems/activesupport-6.1.6.1/lib/active_support/logger.rb:3:in `<top (required)>'
        from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
        from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
        from /usr/local/rvm/gems/default/gems/activesupport-6.1.6.1/lib/active_support.rb:29:in `<top (required)>'
        from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
        from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
        from /usr/local/rvm/gems/default/gems/activesupport-6.1.6.1/lib/active_support/all.rb:3:in `<top (required)>'
        from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
        from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
        from /usr/local/rvm/gems/default/gems/xdrgen-0.1.3/lib/xdrgen.rb:2:in `<top (required)>'
        from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
        from <internal:/usr/local/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
        from /usr/local/rvm/gems/default/gems/xdrgen-0.1.3/bin/xdrgen:3:in `<top (required)>'
        from /usr/local/rvm/gems/default/bin/xdrgen:25:in `load'
        from /usr/local/rvm/gems/default/bin/xdrgen:25:in `<main>'

@overcat overcat force-pushed the pin-concurrent-ruby branch from ec7861a to daa81fe Compare February 4, 2025 02:28
@leighmcculloch
Copy link
Member

leighmcculloch commented Feb 4, 2025

When I run make locally this change doesn't seem to be sufficient at fixing the build and dependency issues. @overcat when you run make does it work for you?

Investigating further here:

@overcat
Copy link
Contributor Author

overcat commented Feb 5, 2025

When I run make locally this change doesn't seem to be sufficient at fixing the build and dependency issues. @overcat when you run make does it work for you?

Investigating further here:

Hi @leighmcculloch, this is because we did not specify the version of the Ruby image in the Makefile, and some dependencies may not be compatible with the latest version of Ruby. Specifying ruby:3.0 can resolve this issue.

If we need to upgrade various dependencies and bump the minimum supported Ruby version, let's do it in another PR.

@leighmcculloch
Copy link
Member

Ah yes I see what you mean. xdrgen builds with Ruby 3.3, but not 3.4. I'll address that in:

@leighmcculloch leighmcculloch enabled auto-merge (squash) February 5, 2025 02:48
@leighmcculloch leighmcculloch merged commit 69b77af into stellar:master Feb 5, 2025
3 checks passed
@overcat overcat deleted the pin-concurrent-ruby branch February 5, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants