Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with eheat #133

Open
Yunuuuu opened this issue Oct 22, 2024 · 3 comments
Open

Integrate with eheat #133

Yunuuuu opened this issue Oct 22, 2024 · 3 comments

Comments

@Yunuuuu
Copy link

Yunuuuu commented Oct 22, 2024

Hi, dear developers, I previously created a pcakge eheat. It bring all ggplot2 extension into ComplexHeatmap, can it be a function to integrated to TidyHeatmap?

@stemangiola
Copy link
Owner

Hello @Yunuuuu, thanks for the message. The two packages work with different layers of commands. I am not sure how the two could interact.

@Yunuuuu
Copy link
Author

Yunuuuu commented Oct 24, 2024

Hello @stemangiola, instead of depending on the package, would it be possible to directly copy the core code from eheat? This way, we could store the ggplot object in a dedicated slot and customize the building process when calling the draw method.

Additionally, one necessary step would be to define a new + method that allows adding all ggplot2 elements to this slot. This way, we can utilize all ggplot (including legends) functions.

@stemangiola
Copy link
Owner

Hello, thanks for the suggestion, I am not sure the design of eheat and tidyHeatmap are compatible. The user interface and philosophy is quite different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants