Skip to content

compatibility with carthage & xcode 8 #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

leoschweizer
Copy link

Hi,

this is the minimal changeset I had to apply to get SQLite.swift working again after upgrading to XCode 8 when included as Carthage dependency.

You might want to include this because right now, if you are on XCode 8, you can't use SQLite.swift (at least through Carthage).

I understand that there are probably more changes required to make it work with CocoaPods and the like, so if you don't want to make this partial change feel free to close this PR 😉

@jberkel
Copy link
Collaborator

jberkel commented Sep 14, 2016

this is already in progress: #475

@leoschweizer
Copy link
Author

@jberkel I'm aware of that, but unfortunately the xcode8 branch does not build with Carthage (at least for the tvos target). Unfortunately my change is probably not compatible to XCode 7 as the Travis result suggests, so I'll just stick with my fork for know until things are sorted out.

@jberkel
Copy link
Collaborator

jberkel commented Sep 14, 2016

ok, what exactly is the change needed for carthage?

@leoschweizer
Copy link
Author

@jberkel I've created another PR on the xcode 8 branch, just a minor change but it seems to work fine now, see #494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants