Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate? #39

Open
stephenplusplus opened this issue Feb 20, 2018 · 5 comments
Open

Deprecate? #39

stephenplusplus opened this issue Feb 20, 2018 · 5 comments

Comments

@stephenplusplus
Copy link
Owner

@ofrobots @JustinBeckwith

Should we kill this thing?

@JustinBeckwith
Copy link
Collaborator

Hah, how about we actually try integrating google-auth-library into a few of the dependents first :P . I'd be happy to review those PRs!

@stephenplusplus
Copy link
Owner Author

stephenplusplus commented Feb 20, 2018

The way our libs work now is something like:

HTTP APIs:
The client library requires @google-cloud/common. Common uses google-auto-auth to make requests before making requests.

GAPIC APIs:
The client library makes all requests through the generated API, which uses google-auto-auth.

So, I think we do have some control over the rollout, but only between the two choices above. Unless there're any objections, I'll start by swapping out GAA for GAL in @google-cloud/common, send a PR, and use that branch to test locally with Storage.

cc @callmehiphop

@nolanmar511
Copy link

Any idea on timeline for upgrading @google-cloud/common to depend on google-auth-library directly? Or on updating google-auto-auto's dependency on google-auth-library ?

I'm working on https://github.com/GoogleCloudPlatform/cloud-profiler-nodejs, which uses @google-cloud/common and we regularly (once every hour) get authorization errors when credentials expire, and so would like to see the changes made in google-auth-library to refresh the token before it expires make it into @google-cloud/common.

@stephenplusplus
Copy link
Owner Author

It would be much faster to get GAL upgraded within this library.

@JustinBeckwith @ofrobots could you review #38?

@JustinBeckwith
Copy link
Collaborator

So I think we pretty much have this worked out. I'd be 👍 for deprecating this officially now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants