-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameter combination logic #92
Comments
I like the proposed syntax, at least for scalar parameters.
…On Tue, Feb 27, 2018 at 12:04 PM, gaow ***@***.***> wrote:
By default we adopt Cartesian product logic when combining parameters.
This behavior can be adjusted either grouping parameters together:
n_df: (100,2), (1000, 4)
Or apply @filter:
n: 100, 1000
df: 2, 4
@filter: (n = 100 and df = 2) or (n = 1000 and df = 4)
A proposed syntax is:
(n, df): (100, 2), (1000, 4)
I will implement this behavior if deemed reasonable.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#92>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABt4xd9UfbQYs_sm_MArfDDQaiJDjA-Tks5tZEOYgaJpZM4SVY39>
.
|
@gaow Seems reasonable to me. |
gaow
added a commit
that referenced
this issue
Mar 4, 2018
This is now supported, though need more unit tests to cover all steps this change may have affected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
By default we adopt Cartesian product logic when combining parameters. This behavior can be adjusted either grouping parameters together:
Or apply
@FILTER
:A proposed syntax is:
I will implement this behavior if deemed reasonable.
The text was updated successfully, but these errors were encountered: