Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter combination logic #92

Closed
gaow opened this issue Feb 27, 2018 · 3 comments
Closed

Parameter combination logic #92

gaow opened this issue Feb 27, 2018 · 3 comments

Comments

@gaow
Copy link
Member

gaow commented Feb 27, 2018

By default we adopt Cartesian product logic when combining parameters. This behavior can be adjusted either grouping parameters together:

n_df: (100,2), (1000, 4)

Or apply @FILTER:

n: 100, 1000
df: 2, 4
@FILTER: (n = 100 and df = 2) or (n = 1000 and df = 4)

A proposed syntax is:

(n, df): (100, 2), (1000, 4)

I will implement this behavior if deemed reasonable.

@stephens999
Copy link
Contributor

stephens999 commented Feb 28, 2018 via email

@pcarbo
Copy link
Member

pcarbo commented Mar 1, 2018

@gaow Seems reasonable to me.

gaow added a commit that referenced this issue Mar 4, 2018
@gaow
Copy link
Member Author

gaow commented Mar 5, 2018

This is now supported, though need more unit tests to cover all steps this change may have affected.

@gaow gaow closed this as completed Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants