From 3622aaccfce1d85b5cf51bf087cd65b523a9571c Mon Sep 17 00:00:00 2001 From: Mai Bui Date: Tue, 27 Sep 2022 10:52:07 -0700 Subject: [PATCH] Remove shell=True (#300) Signed-off-by: maipbui Signed-off-by: maipbui --- .../sonic_platform_base/sonic_pcie/pcie_common.py | 8 ++++---- sonic-xcvrd/xcvrd/xcvrd.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sonic-pcied/tests/mocked_libs/sonic_platform_base/sonic_pcie/pcie_common.py b/sonic-pcied/tests/mocked_libs/sonic_platform_base/sonic_pcie/pcie_common.py index 58590ea8cef9..127c614cde17 100644 --- a/sonic-pcied/tests/mocked_libs/sonic_platform_base/sonic_pcie/pcie_common.py +++ b/sonic-pcied/tests/mocked_libs/sonic_platform_base/sonic_pcie/pcie_common.py @@ -39,14 +39,14 @@ def get_pcie_device(self): pciList = [] p1 = "^(\w+):(\w+)\.(\w)\s(.*)\s*\(*.*\)*" p2 = "^.*:.*:.*:(\w+)\s*\(*.*\)*" - command1 = "sudo lspci" - command2 = "sudo lspci -n" + command1 = ["sudo", "lspci"] + command2 = ["sudo", "lspci", "-n"] # run command 1 - proc1 = subprocess.Popen(command1, shell=True, universal_newlines=True, stdout=subprocess.PIPE) + proc1 = subprocess.Popen(command1, universal_newlines=True, stdout=subprocess.PIPE) output1 = proc1.stdout.readlines() (out, err) = proc1.communicate() # run command 2 - proc2 = subprocess.Popen(command2, shell=True, universal_newlines=True, stdout=subprocess.PIPE) + proc2 = subprocess.Popen(command2, universal_newlines=True, stdout=subprocess.PIPE) output2 = proc2.stdout.readlines() (out, err) = proc2.communicate() diff --git a/sonic-xcvrd/xcvrd/xcvrd.py b/sonic-xcvrd/xcvrd/xcvrd.py index 55d5da8f1e2f..ac9ea7c7f195 100644 --- a/sonic-xcvrd/xcvrd/xcvrd.py +++ b/sonic-xcvrd/xcvrd/xcvrd.py @@ -907,7 +907,7 @@ def is_fast_reboot_enabled(): keys = fastboot_tbl.getKeys() if "system" in keys: - output = subprocess.check_output('sonic-db-cli STATE_DB get "FAST_REBOOT|system"', shell=True, universal_newlines=True) + output = subprocess.check_output(['sonic-db-cli', 'STATE_DB', 'get', "FAST_REBOOT|system"], universal_newlines=True) if "1" in output: fastboot_enabled = True