Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data attributes from html options #47

Merged
merged 2 commits into from
Sep 7, 2020
Merged

Add data attributes from html options #47

merged 2 commits into from
Sep 7, 2020

Conversation

scottbarrow
Copy link
Contributor

@scottbarrow scottbarrow commented Sep 7, 2020 •
edited
Loading

Type of PR - enhancement

Description

  • Allow data attributes to be passed in html_options, without removing sgid, signed_params
  • Disallow overwriting sgid, signed_params data-attributes

Fixes #43

Why should this be added

Allows Futurism to respect developers wishes to pass in data-attributes e.g. Stimulus controllers

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing

@scottbarrow scottbarrow force-pushed the 43-data-attributes-html-options branch from 10753cf to e7e92e4 Compare September 7, 2020 02:25
@julianrubisch julianrubisch merged commit b36be8e into stimulusreflex:43-data-attributes-html-options Sep 7, 2020
@scottbarrow scottbarrow deleted the 43-data-attributes-html-options branch September 7, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottbarrow @julianrubisch