Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflex not triggered when a Stimulus controller is also attached to a field #678

Closed
cmer opened this issue Dec 30, 2023 · 4 comments
Closed

Comments

@cmer
Copy link
Contributor

cmer commented Dec 30, 2023

Bug Report

Describe the bug

Reflexes are not triggered when any other Stimulus controller is attached to an input field.

To Reproduce

Attaching a Stimulus controller to a text field prevent reflexes from running.

Expected behavior

The reflex should get triggered in both cases.

Screenshots or reproduction

See: https://github.com/cmer/stimulus-reflex-bug-repro

And video demo: https://share.cleanshot.com/7sz67SPmk8sP8PGtL6xJ

Versions

StimulusReflex

  • Gem: 3.5.0.rc3
  • Node package: 3.5.0.rc3

Browser

  • Browser: Any
@cmer cmer changed the title Reflex not triggered when a Stimulus Controller is also attached to a field Reflex not triggered when a Stimulus controller is also attached to a field Dec 30, 2023
@marcoroth
Copy link
Member

marcoroth commented Jan 4, 2024

Thanks for reporting this and for providing a repro @cmer. I was able to reproduce it in the test-suite and I'm currently looking into the best way to fix it! Thanks!

@marcoroth
Copy link
Member

This should be resolved via #670

@cmer
Copy link
Contributor Author

cmer commented Jan 4, 2024

Thank you SO MUCH! Awesome!!! Can't wait to give it a shot. You have a typo, btw. Left a comment.

@marcoroth
Copy link
Member

marcoroth commented Mar 12, 2024

This should be resolved with the release of v3.5.0.rc4. I'm going to close this issue, but please feel free to re-open if you are still seeing something unexpected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants