-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mono timer #254
Fix mono timer #254
Conversation
db61b7b
to
352ad75
Compare
I should make cargo fmt run automatically before I commit to this repo 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oh, but since it's a breaking change it should be mentioned in the CHANGELOG. DOH! |
Oops, I'll just do that manually with another commit :) |
Maybe we should add a CONTRIBUTING.md that just says "Oh, and don't forget to modify the changelog" |
Yeah. |
Closes #252
Unfortunately this a breaking change as we now need to take the DCP peripheral when starting the mono timer.
I also added a note from one of the linked issues about
mono_timer
being stopped when hprintln is running.For reference, here is a code sample that does not work currently, but does with this fix