Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPI frame format config method #280

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Add SPI frame format config method #280

merged 1 commit into from
Nov 5, 2020

Conversation

repnop
Copy link
Contributor

@repnop repnop commented Oct 26, 2020

Fixes #279

This adds a method to the SPI type which allows configuring which frame format to use for data transfers.

TheZoq2
TheZoq2 requested changes Oct 27, 2020
View reviewed changes
Copy link
Member

@TheZoq2 TheZoq2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good apart from a few naming and doc issues.

From reading the reference manual, it looks like the term "frame format" refers to both bit order and word length. Would SpiBitOrder be a better name?

@TheZoq2 TheZoq2 added the hacktoberfest-accepted Not spam and submitted in october label Oct 27, 2020
@repnop repnop requested a review from TheZoq2 November 3, 2020 15:12
TheZoq2
TheZoq2 approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@TheZoq2 TheZoq2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheZoq2 TheZoq2 merged commit a6dde78 into stm32-rs:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheZoq2 TheZoq2 TheZoq2 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Not spam and submitted in october
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SPI no frame format option.
2 participants
@repnop @TheZoq2