Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rcc config #337

Merged
merged 1 commit into from
Oct 31, 2021
Merged

rcc config #337

merged 1 commit into from
Oct 31, 2021

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented May 18, 2021 •
edited
Loading

No description provided.

@TheZoq2
Copy link
Member

TheZoq2 commented May 26, 2021

Nice, this seems like an excellent change. I'll try to find the time to give it a proper review soon

@burrbull burrbull mentioned this pull request Jul 13, 2021
Merged
@burrbull burrbull marked this pull request as ready for review July 13, 2021 13:57
TeXitoi
TeXitoi approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@TeXitoi TeXitoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, great, we could even add unit test to check we do the good autoconfiguration!

@TeXitoi
Copy link
Contributor

TeXitoi commented Jul 13, 2021

@burrbull did you use this branch on some of your project, on real hardware? If yes, I'm OK to merge it.

@burrbull
Copy link
Member Author

@burrbull did you use this branch on some of your project, on real hardware? If yes, I'm OK to merge it.

I would rather have someone else recheck this.

@burrbull burrbull mentioned this pull request Sep 8, 2021
Merged
@TheZoq2 TheZoq2 mentioned this pull request Oct 13, 2021
Merged
@burrbull burrbull force-pushed the rcc_config branch 2 times, most recently from 64331e7 to ec85953 Compare October 26, 2021 10:27
@burrbull
Copy link
Member Author

Rebased.
@jasLogic Can you test this?

@jasLogic
Copy link
Contributor

Everything seems to work fine but I only really tested if my changes still function properly.

@burrbull burrbull merged commit 6675fe2 into stm32-rs:master Oct 31, 2021
@qthree qthree mentioned this pull request Nov 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeXitoi TeXitoi TeXitoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@burrbull @TheZoq2 @TeXitoi @jasLogic