Fix compile error when max() is a template function #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When max() is a template function instead of a macro the two arguments to it must be of same type. The problem was raised in issue stoduk#6 "Cant compile for nodemcu/ESP8266" and I had the same problem when trying to use the library. This change is the same that Anthony Toole proposed as a fix for this issue. I have verified that with this change the library works also with ESP8266 core 2.6.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When max() is a template function instead of a macro the two arguments
to it must be of same type.
The problem was raised in issue
#6
"Cant compile for nodemcu/ESP8266"
and I had the same problem when trying to use the library.
This change is the same that Anthony Toole proposed as a fix for this
issue. I have verified that with this change the library works also
with ESP8266 core 2.6.3.