This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: urijs treats leading whitespaces differently #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
force-pushed
the
fix/urijs/whitespaces
branch
from
45f50a4
to
6dd3fc7
Compare
marbemac
reviewed
Jun 6, 2022
| "@types/urijs": "^1.19.19", | ||
| "dependency-graph": "~0.11.0", | ||
| "fast-memoize": "^2.5.2", | ||
| "immer": "^9.0.6", | ||
| "lodash": "^4.17.21", | ||
| "tslib": "^2.3.1", | ||
| "urijs": "^1.19.10" | ||
| "urijs": "^1.19.11" |
There was a problem hiding this comment.
do we even need urijs anymore? or do the node versions/browsers we target now all have proper support for URL?
There was a problem hiding this comment.
meh nvm, we're not really putting work towards maintaining this package in future in any case
There was a problem hiding this comment.
we don't need urijs, but yeah, too much effort to rewrite it to use URL.
marbemac
approved these changes
Jun 6, 2022
|
🎉 This PR is included in version 3.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed in order to release json-ref-resolver and close stoplightio/spectral#2017
Regressed in 265ae19
Unfortunately, the CI checks didn't run on that PR, so we couldn't catch that regression.
Luckily they were executed on the master branch, so no new release has been made.