fix: add operation-operationId-valid-in-url #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to check for valid url characters in operationId
tbarn
approved these changes
Feb 1, 2019
|
Code Climate has analyzed commit 486bc00 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.0% change). View more on Code Climate. |
marbemac
pushed a commit
that referenced
this pull request
Feb 4, 2019
to check for valid url characters in operationId
karol-maciaszek
added a commit
that referenced
this pull request
Feb 19, 2019
* fix: a typo and a probable cut-and-paste error src/rulesets/oas3/index.ts and associated tests: 'specifcication' -> 'specification' in a comment `servers` must be, and is tested against, being an array not a string * fix: allow path-keys-no-trailing-slash empty slash (#85) * fix: add operation-operationId-valid-in-url (#86) to check for valid url characters in operationId * fix: SL-1709 paths emitted by ajv are not json pointers * fix: SL-1709 fixed json dependency version
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to check for valid url characters in operationId
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix (slash kind of feature).
What is the current behavior?
closes #84
Does this PR introduce a breaking change?
No