Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should refuse SQL transaction statements BEGIN / COMMIT / ROLLBACK from the API #865

Open
brodycj opened this issue May 3, 2019 · 1 comment

Comments

@brodycj
Copy link
Contributor

brodycj commented May 3, 2019

Related to #863: I think this plugin should refuse to execute BEGIN, COMMIT, and ROLLBACK statements since they may interfere with the existing transaction mechanism, lead to cryptic error messages (see #863), lead to untested & undefined behavior, and maybe even lead to a risk of data loss.

I think this should be in a major version release since it could be a breaking change for some users, including people using TypeORM (see #863 & typeorm/typeorm#4075).

A better long-term solution would probably be a redesigned plugin with a redesigned API (see #548, #862).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant