Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning in console after installing addon #204

Closed
1 of 11 tasks
markokos01 opened this issue Aug 7, 2023 · 2 comments
Closed
1 of 11 tasks

Warning in console after installing addon #204

markokos01 opened this issue Aug 7, 2023 · 2 comments
Labels
category: bug Something isn't working

Comments

@markokos01
Copy link

markokos01 commented Aug 7, 2023

Affected design types

  • figma
  • figspec
  • link
  • image
  • iframe

Describe the bug

I get the warning in the console after I added addon in main.ts.

Warning: render: key is not a prop. Trying to access it will result in undefined being returned. If you need to access the same value within the child component, you should pass it as a different prop. (https://fb.me/react-special-props)

How to reproduce the bug?

  1. Install @storybook/addon-designs
  2. Add addon to main.ts
  3. Run storybook

Expected behaviour

I do not expect any errors in console.

Environment

  • Chrome / Chromium / Chromium based browsers
  • Firefox
  • macOS Safari
  • iOS Safari
  • Samsung Internet
  • Other

Affected versions

7.0.1

Storybook versions

7.2.1

@markokos01 markokos01 added the category: bug Something isn't working label Aug 7, 2023
@mayerraphael
Copy link

mayerraphael commented Aug 10, 2023

Problem is the register Method in index.js line 50

...
 else {
            addons.addPanel(PanelName, {
                title: title,
                paramKey: ParameterName,
                render: function (_a) {
                    var active = _a.active, key = _a.key;  // This line here.
                    return (jsx(AddonPanel, { key: key, active: !!active },
                        jsx(ErrorBoundary, null,
                            jsx(Wrapper, { active: !!active }))));
                },
            });
        }
    });
...

@pocka
Copy link
Collaborator

pocka commented Aug 10, 2023

Upstream bug.
storybookjs/storybook#23782

@pocka pocka closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants