fix(upgrade): dont upgrade nx packages

storybookjs · May 5, 2023 · 5aa1ea5 · 5aa1ea5
1 parent 91b4484
commit 5aa1ea5
Showing 1 changed file with 16 additions and 0 deletions.
diff --git a/code/lib/cli/src/upgrade.ts b/code/lib/cli/src/upgrade.ts
@@ -46,6 +46,8 @@ const excludeList = [
   '@storybook/test-runner',
   '@storybook/testing-library',
   '@storybook/testing-react',
+  '@nrwl/storybook',
+  '@nx/storybook',
 ];
 export const isCorePackage = (pkg: string) =>
   pkg.startsWith('@storybook/') &&
@@ -135,6 +137,19 @@ export const addExtraFlags = (
   );
 };
 
+const addNxPackagesToReject = (flags: string[]) => {
+  const newFlags = [...flags];
+  if (flags.indexOf('--reject') > -1) {
+    newFlags[flags.indexOf('--reject') + 1] = `${
+      flags[flags.indexOf('--reject') + 1]
+    },@nrwl/storybook,@nx/storybook`;
+  } else {
+    newFlags.push('--reject');
+    newFlags.push('@nrwl/storybook,@nx/storybook');
+  }
+  return newFlags;
+};
+
 export interface UpgradeOptions {
   tag: string;
   prerelease: boolean;
@@ -190,6 +205,7 @@ export const doUpgrade = async ({
   flags.push('--target');
   flags.push(target);
   flags = addExtraFlags(EXTRA_FLAGS, flags, packageManager.retrievePackageJson());
+  flags = addNxPackagesToReject(flags);
   const check = spawnSync('npx', ['npm-check-updates@latest', '/storybook/', ...flags], {
     stdio: 'pipe',
     shell: true,