Merge pull request #22379 from storybookjs/valentin/add-angular-prere…

…lease-sandbox Add Angular Prerelease sandbox
storybookjs · May 4, 2023 · 7e57324 · 7e57324
2 parents c53db1f + a19905f
commit 7e57324
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 15 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -701,30 +701,30 @@ workflows:
           requires:
             - build
       - create-sandboxes:
-          parallelism: 31
+          parallelism: 32
           requires:
             - build
       # - smoke-test-sandboxes: # disabled for now
       #     requires:
       #       - create-sandboxes
       - build-sandboxes:
-          parallelism: 31
+          parallelism: 32
           requires:
             - create-sandboxes
       - chromatic-sandboxes:
-          parallelism: 31
+          parallelism: 32
           requires:
             - build-sandboxes
       - e2e-production:
-          parallelism: 31
+          parallelism: 32
           requires:
             - build-sandboxes
       - e2e-dev:
           parallelism: 4
           requires:
             - create-sandboxes
       - test-runner-production:
-          parallelism: 31
+          parallelism: 32
           requires:
             - build-sandboxes
       # TODO: reenable once we find out the source of flakyness

diff --git a/code/e2e-tests/framework-nextjs.spec.ts b/code/e2e-tests/framework-nextjs.spec.ts
@@ -28,22 +28,23 @@ test.describe('Next.js', () => {
       sbPage = new SbPage(page);
     });
 
-    test('should lazy load images by default', async () => {
+    // TODO: Test is flaky, investigate why
+    test.skip('should lazy load images by default', async () => {
       await sbPage.navigateToStory('frameworks/nextjs/Image', 'lazy');
 
       const img = sbPage.previewRoot().locator('img');
 
       expect(await img.evaluate<boolean, HTMLImageElement>((image) => image.complete)).toBeFalsy();
     });
 
-    // TODO: Test is very flaky, investigate why
-    // test('should eager load images when loading parameter is set to eager', async () => {
-    //   await sbPage.navigateToStory('frameworks/nextjs/Image', 'eager');
+    // TODO: Test is flaky, investigate why
+    test.skip('should eager load images when loading parameter is set to eager', async () => {
+      await sbPage.navigateToStory('frameworks/nextjs/Image', 'eager');
 
-    //   const img = sbPage.previewRoot().locator('img');
+      const img = sbPage.previewRoot().locator('img');
 
-    //   expect(await img.evaluate<boolean, HTMLImageElement>((image) => image.complete)).toBeTruthy();
-    // });
+      expect(await img.evaluate<boolean, HTMLImageElement>((image) => image.complete)).toBeTruthy();
+    });
   });
 
   test.describe('next/navigation', () => {

diff --git a/code/lib/cli/src/sandbox-templates.ts b/code/lib/cli/src/sandbox-templates.ts
@@ -276,7 +276,6 @@ const baseTemplates = {
       builder: '@storybook/builder-webpack5',
     },
     skipTasks: ['e2e-tests-dev'],
-    inDevelopment: true,
   },
   'angular-cli/default-ts': {
     name: 'Angular CLI (latest)',
@@ -473,8 +472,6 @@ export const allTemplates: Record<TemplateKey, Template> = {
 export const ci: TemplateKey[] = ['cra/default-ts', 'react-vite/default-ts'];
 export const pr: TemplateKey[] = [
   ...ci,
-  // TODO: add this after the sandbox is ready in the sandboxes repo
-  // 'angular-cli/prerelease',
   'angular-cli/default-ts',
   'vue3-vite/default-ts',
   'vue-cli/vue2-default-js',
@@ -497,6 +494,7 @@ export const merged: TemplateKey[] = [
 ];
 export const daily: TemplateKey[] = [
   ...merged,
+  'angular-cli/prerelease',
   'cra/default-js',
   'react-vite/default-js',
   'vue3-vite/default-js',